On Wed Aug 6, 2025 at 5:13 PM CEST, Konrad Dybcio wrote: > On 8/6/25 5:10 PM, Griffin Kroah-Hartman wrote: >> Add the required node for haptic playback (Awinic AW86927). >> >> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@xxxxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 18 +++++++++++++++++- >> 1 file changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> index 4c6cb4a644e2..9576efdf1e8d 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> @@ -866,7 +866,16 @@ ocp96011_sbu_mux: endpoint { >> }; >> }; >> >> - /* AW86927FCR haptics @ 5a */ >> + vibrator@5a { >> + compatible = "awinic,aw86927"; > > I noticed the suffix is absent in the compatible - does it matter > for discerning the particular chip and other variants? > Anyway, so long as you and the bindings folks agree on it: According to the datasheet, the main name is AW86927, while the part number of this particular one is AW86927FCR. I'm not aware of any other variants of the 86927 though. At least for some audio chip from Awinic there seems to be different variants with the same number with a different suffix that have a different amount of pins, but I really don't know 100%. https://www.awinic.com/en/search/all?titleSearch=AW86927 At least I don't find any non-FCR variants here. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> > > Konrad