On Sun, Jul 20, 2025 at 04:02:09PM +0000, Rahul Rameshbabu wrote:
[...]
> > diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
> > index b15b3cddad4e..7f5403d6c51c 100644
> > --- a/rust/helpers/helpers.c
> > +++ b/rust/helpers/helpers.c
> > @@ -25,6 +25,7 @@
> > #include "fs.c"
> > #include "io.c"
> > #include "jump_label.c"
> > +#include "kref.c"
> > #include "kunit.c"
> > #include "mm.c"
> > #include "mutex.c"
> > diff --git a/rust/helpers/kref.c b/rust/helpers/kref.c
> > new file mode 100644
> > index 000000000000..25eeb0a724ac
> > --- /dev/null
> > +++ b/rust/helpers/kref.c
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +#include <linux/kref.h>
> > +
> > +void rust_helper_kref_get(struct kref *kref)
> > +{
> > + kref_get(kref);
> > +}
> > +
> > +void rust_helper_kref_put(struct kref *kref, void (*release)(struct kref *kref))
> > +{
> > + kref_put(kref, release);
> > +}
>
> I am about to send out my v3, and this patch will no longer be needed.
> Would it make sense to send this out separately? I can also just keep it
> stashed away till someone needs it.
>
I think you just drop this, we will have the Refcount abstraction:
https://lore.kernel.org/rust-for-linux/20250622125802.3224264-1-gary@xxxxxxxxxx/
, and we can build an kref API on top of that.
Thanks!
Regards,
Boqun
> Thanks,
> Rahul Rameshbabu
>
