On 19-08-25, 22:00, Yulin Lu wrote:
> From: luyulin <luyulin@xxxxxxxxxxxxxxxxxx>
>
> Created the eswin phy driver directory and added support for
> the SATA phy driver on the EIC7700 SoC platform.
>
> Signed-off-by: luyulin <luyulin@xxxxxxxxxxxxxxxxxx>
Please use full name as you have used in the copyright notices
> +#define SATA_P0_PHY_TX_PREEMPH_GEN2 (0x05 << 8)
> +#define SATA_P0_PHY_TX_PREEMPH_GEN3 (0x08 << 16)
> +#define SATA_MPLL_MULTIPLIER (0x3c << 16)
Use GENMASK for these
> +static int eic7700_sata_phy_init(struct phy *phy)
> +{
> + struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
> + u32 val = 0;
> + int ret = 0;
both initializations are superfluous
> +static int eic7700_sata_phy_exit(struct phy *phy)
> +{
> + struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
> + u32 val = 0;
here and other places
> +static struct platform_driver eic7700_sata_phy_driver = {
> + .probe = eic7700_sata_phy_probe,
> + .driver = {
> + .of_match_table = eic7700_sata_phy_of_match,
> + .name = "eswin,sata-phy",
> + .suppress_bind_attrs = true,
why?
--
~Vinod
