On Thu, Aug 28, 2025 at 12:01:31AM +0200, David Hildenbrand wrote:
> It's no longer required to use nth_page() when iterating pages within a
> single SG entry, so let's drop the nth_page() usage.
>
> Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Cc: Alex Dubov <oakad@xxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
LGTM, so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> ---
> drivers/memstick/host/jmb38x_ms.c | 3 +--
> drivers/memstick/host/tifm_ms.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index cddddb3a5a27f..79e66e30417c1 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -317,8 +317,7 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host)
> unsigned int p_off;
>
> if (host->req->long_data) {
> - pg = nth_page(sg_page(&host->req->sg),
> - off >> PAGE_SHIFT);
> + pg = sg_page(&host->req->sg) + (off >> PAGE_SHIFT);
> p_off = offset_in_page(off);
> p_cnt = PAGE_SIZE - p_off;
> p_cnt = min(p_cnt, length);
> diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
> index db7f3a088fb09..0b6a90661eee5 100644
> --- a/drivers/memstick/host/tifm_ms.c
> +++ b/drivers/memstick/host/tifm_ms.c
> @@ -201,8 +201,7 @@ static unsigned int tifm_ms_transfer_data(struct tifm_ms *host)
> unsigned int p_off;
>
> if (host->req->long_data) {
> - pg = nth_page(sg_page(&host->req->sg),
> - off >> PAGE_SHIFT);
> + pg = sg_page(&host->req->sg) + (off >> PAGE_SHIFT);
> p_off = offset_in_page(off);
> p_cnt = PAGE_SIZE - p_off;
> p_cnt = min(p_cnt, length);
> --
> 2.50.1
>
