Re: [PATCH v7 08/19] scsi: detect support for command duration limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/07/2025 13:48, Diangang Li wrote:
> On Tue, Jul 22, 2025 at 06:37:50PM +0900, Damien Le Moal wrote:
>> On 7/22/25 6:32 PM, Friedrich Weber wrote:
>>> On 14/07/2025 04:48, Damien Le Moal wrote:
>>>> On 7/10/25 5:41 PM, Friedrich Weber wrote:
>>>>> Thanks for looking into this, it is definitely a strange problem.
>>>>>
>>>>> Considering these drives don't support CDL anyway: Do you think it would
>>>>> be possible to provide an "escape hatch" to disable only the CDL checks
>>>>> (a module parameter?) so hotplug can work for the user again for their
>>>>> device? If I see correctly, disabling just the CDL checks is not
>>>>> possible (without recompiling the kernel) -- scsi_mod.dev_flags can be
>>>>> used to disable RSOC, but I guess that has other unintended consequences
>>>>> too, so a more "targeted" escape hatch would be nice.
>>>>
>>>> Could you test the attached patch ? That should solve the issue.
>>>>
>>>
>>> Thanks for the patch! The user tested it on top of a 6.15.6 kernel and
>>> with the SAS3008 HBA, and indeed:
>>>
>>> - under 6.15.6, hotplug fails with the log messages mentioned in my
>>> first message,
>>> - with your patch on top, hotplug works again.
>>
>> OK. Will post a proper patch then (tomorrow).
>> Thanks for testing.
>>
> 
> Hi Damien,
> 
> Are you planning to post a formal patch to upstream?

Damien did post a patch [1], but as discussed there [2], it was not
effective in our case because it was targeted at SATA drives, and we
realized all tests were actually done using SAS drives. Sorry for the
confusion, it might have been better if I had posted my follow-up
yesterday [3] in the other thread instead.

[1] https://lore.kernel.org/all/20250723052334.32298-1-dlemoal@xxxxxxxxxx/
[2]
https://lore.kernel.org/all/a345c99d-864b-4dde-b755-b61a085508a8@xxxxxxxxxxx/#t
[3]
https://lore.kernel.org/all/eb3778e5-dfdb-4382-8cc6-da6459f14a46@xxxxxxxxxxx/





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux