Re: [PATCH v2 1/3] ata: libata-eh: Make ata_eh_followup_srst_needed() return a bool

[Hannes Reinecke <hare@xxxxxxx>]

On 7/8/25 09:36, Damien Le Moal wrote:
> ata_eh_followup_srst_needed() returns an integer used as a boolean. So
> change this function to return that type.
>
> No functional changes.
>
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> ---
>   drivers/ata/libata-eh.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 42aafb1ddb5a..436536112043 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -2781,15 +2781,15 @@ static int ata_do_reset(struct ata_link *link, ata_reset_fn_t reset,
>   	return reset(link, classes, deadline);
>   }
>   
> -static int ata_eh_followup_srst_needed(struct ata_link *link, int rc)
> +static bool ata_eh_followup_srst_needed(struct ata_link *link, int rc)
>   {
>   	if ((link->flags & ATA_LFLAG_NO_SRST) || ata_link_offline(link))
> -		return 0;
> +		return false;
>   	if (rc == -EAGAIN)
> -		return 1;
> +		return true;
>   	if (sata_pmp_supported(link->ap) && ata_is_host_link(link))
> -		return 1;
> -	return 0;
> +		return true;
> +	return false;
>   }
>   
>   int ata_eh_reset(struct ata_link *link, int classify,

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes