Hi Damien, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.16-rc5 next-20250704] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/ata-libata-eh-Make-ata_eh_followup_srst_needed-return-a-bool/20250707-190306 base: linus/master patch link: https://lore.kernel.org/r/20250707105931.548315-3-dlemoal%40kernel.org patch subject: [PATCH 2/3] ata: libata-eh: Remove ata_do_eh() config: csky-randconfig-001-20250708 (https://download.01.org/0day-ci/archive/20250708/202507081215.hXgFd0Tv-lkp@xxxxxxxxx/config) compiler: csky-linux-gcc (GCC) 13.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250708/202507081215.hXgFd0Tv-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202507081215.hXgFd0Tv-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/ata/libata-eh.c: In function 'ata_std_error_handler': >> drivers/ata/libata-eh.c:4056:27: error: 'sata_sff_hardreset' undeclared (first use in this function); did you mean 'sata_std_hardreset'? 4056 | hardreset == sata_sff_hardreset) && !sata_scr_valid(&ap->link)) | ^~~~~~~~~~~~~~~~~~ | sata_std_hardreset drivers/ata/libata-eh.c:4056:27: note: each undeclared identifier is reported only once for each function it appears in vim +4056 drivers/ata/libata-eh.c 4038 4039 /** 4040 * ata_std_error_handler - standard error handler 4041 * @ap: host port to handle error for 4042 * 4043 * Perform standard error handling sequence. 4044 * 4045 * LOCKING: 4046 * Kernel thread context (may sleep). 4047 */ 4048 void ata_std_error_handler(struct ata_port *ap) 4049 { 4050 struct ata_port_operations *ops = ap->ops; 4051 ata_reset_fn_t hardreset = ops->hardreset; 4052 int rc; 4053 4054 /* Ignore built-in hardresets if SCR access is not available */ 4055 if ((hardreset == sata_std_hardreset || > 4056 hardreset == sata_sff_hardreset) && !sata_scr_valid(&ap->link)) 4057 hardreset = NULL; 4058 4059 ata_eh_autopsy(ap); 4060 ata_eh_report(ap); 4061 4062 rc = ata_eh_recover(ap, ops->prereset, ops->softreset, 4063 hardreset, ops->postreset, NULL); 4064 if (rc) { 4065 struct ata_device *dev; 4066 4067 ata_for_each_dev(dev, &ap->link, ALL) 4068 ata_dev_disable(dev); 4069 } 4070 4071 ata_eh_finish(ap); 4072 } 4073 EXPORT_SYMBOL_GPL(ata_std_error_handler); 4074 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
