On Tue, Jul 01, 2025 at 09:13:59AM +0900, Damien Le Moal wrote: (snip) > Though DIPM is disabled on > a drive by default thanks to the "Software Settings Preservation > feature", DIPM may have been enabled by the system firmware when using > the LPM policy "Keep FW settings" (ATA_LPM_UNKNOWN). I see that you improved the commit message, but I actually meant that maybe we should mention this in the comment above the disabling of DIPM in ata_dev_config_lpm(). (Since someone just reading AHCI 1.3.1, "8.3.1.1 Device Initiated" will probably read this sentence: By default, a device that supports initiating interface power management states has the capability disabled. You basically need to read ACS-6 or SATA 3.5a to find out about "Software Settings Preservation feature" and that DIPM can actually stay enabled across a COMRESET.) Regardless: Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
