On Mon, Jun 30, 2025 at 03:26:36PM +0900, Damien Le Moal wrote: > ata_dev_config_lpm() prints the message "LPM support broken, forcing > max_power" for devices that have the ATA_QUIRK_NOLPM quirk flag set. > This messages is repeated for every device revalidation, which is not > necessary, but also erroneously printed for devices without a broken LPM > support when connected to a port that does not support LPM (e.g. because > the port is an external one with hotplug capability). > > Since in all cases the device port target_lpm_policy is set to > ATA_LPM_MAX_POWER, avoid the "LPM broken" message repetition and > erroneous output by generating it only if the port target_lpm_policy is > not already set to ATA_LPM_MAX_POWER. > > This change will suppress the "LPM broken" message for genuine cases of > a device having broken LPM if the initial LPM policy is set to > ATA_LPM_MAX_POWER through CONFIG_SATA_MOBILE_LPM_POLICY. This is not a > problem as the ATA_LPM_MAX_POWER policy implies that LPM is disabled and > unused, which is safe for devices with broken LPM. > > Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx> Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
