On Fri, 27 Jun 2025 at 03:14, Niklas Cassel <cassel@xxxxxxxxxx> wrote:
>
> - Use the correct DMI identifier for ASUSPRO-D840SA LPM quirk such that
> the quirk actually gets applied (me)
I've obviously pulled this, but it made me think (once again) that our
DMI matching routines are incredibly odd and hard to use.
Maybe "hard to use" isn't the right phrase: it's just that they are
pretty inflexible and you have to write out the exact right
incantation.
Yes, we have that whole "exact vs relaxed" string comparison thing,
and default to a relaxed comparison (and almost everybody uses that).
The difference there is "strcmp" vs "strstr".
But it still requires the exact slot.
So it's still incredibly inflexible with the whole "oh, you wanted to
compare the *BOARD* name, not the BIOS vendor name or the system
vendor name".
Yes, in some situations you probably do want the specificity, but I do
suspect we could have been much more relaxed, and have some kind of
"board / bios / vendor - who cares?" model of DMI matching (and same
for the whole "name vs version").
Because I strongly suspect that if you had two strings like "ASUSTeK
COMPUTER INC." and "ASUSPRO D840MB_M840SA", and you just asked for the
sane match, it would all just work without having to specify that it's
DMI_SYS_VENDOR / DMI_PRODUCT_NAME.
So the whole "you need to specify the exact DMI slot to match" does
seem counter-productive.
That said, it's probably much too late to worry about this, and
obviously the whole baroque exact slot matching model mostly does
work.
Except when the slot gets copy-pasted from the entry above, which used
a different one because one vendor filled in "version" instead of
"product name".
Linus
