Re: [PATCH v2 3/6] ata: Fix SATA_MOBILE_LPM_POLICY description in Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 27, 2025 at 04:52:04PM +0900, Damien Le Moal wrote:
> Improve the description of the possible default SATA link power
> management policies and add the missing description for policy 5.
> No functional changes.
> 
> Fixes: a5ec5a7bfd1f ("ata: ahci: Support state with min power but Partial low power state")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
> ---
>  drivers/ata/Kconfig | 36 ++++++++++++++++++++++++++----------
>  1 file changed, 26 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index e00536b49552..1d53d7b568bd 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -117,23 +117,39 @@ config SATA_AHCI
>  
>  config SATA_MOBILE_LPM_POLICY
>  	int "Default SATA Link Power Management policy"
> -	range 0 4
> +	range 0 5
>  	default 3
>  	depends on SATA_AHCI
>  	help
>  	  Select the Default SATA Link Power Management (LPM) policy to use
>  	  for chipsets / "South Bridges" supporting low-power modes. Such
>  	  chipsets are ubiquitous across laptops, desktops and servers.
> -
> -	  The value set has the following meanings:
> +	  Each policy combines power saving states and features:
> +	   - Partial: The Phy logic is powered but is in a reduced power
> +                      state. The exit latency from this state is no longer than
> +                      10us).
> +	   - Slumber: The Phy logic is powered but is in an even lower power
> +                      state. The exit latency from this state is potentially
> +		      longer, but no longer than 10ms.
> +	   - DevSleep: The Phy logic may be powered down. The exit latency from
> +	               this state is no longer than 20 ms, unless otherwise
> +		       specified by DETO in the device Identify Device Data log.
> +	   - HIPM: Host Initiated Power Management (host automatic transisitons

s/transisitons/transitions/

Perhaps:
s/automatic/automatically/


> +		   to partial and slumber).
> +	   - DIPM: Device Initiated Power Management (device automatic

Perhaps:
s/automatic/automatically/


> +		   transitions to partial and slumber).

With that:
Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux