Hi, On 23-Jun-25 6:27 PM, Niklas Cassel wrote: > While most entries in ahci_broken_lpm(), for Lenovo based boards, Note the Lenovo matching is done on Lenovo laptop model / product names not on the (mother/main)board names. > match on > DMI_PRODUCT_VERSION, ASUS apparently store the board name in > DMI_PRODUCT_NAME rather than DMI_PRODUCT_VERSION. Actually Lenovo is the weird one here, all other vendors store the laptop model-name in PRODUCT_NAME rather then in PRODUCT_VERSION. For motherboards the motherboard modelnr is typically stored in BOARD_NAME and what is in PRODUCT_NAME varies. E.g. my MSI B550M PRO-VDH desktop motherboard has: DMI_BOARD_NAME "B550M PRO-VDH WIFI (MS-7C95)" DMI_PRODUCT_NAME "MS-7C95" So you may want to reword the commit message a bit. Either way the patch contents looks good to me: Reviewed-by: Hans de Goede <hansg@xxxxxxxxxx> Regards, Hans > > Use the correct DMI identifier (DMI_PRODUCT_NAME) to match the > ASUSPRO-D840SA board, such that the quirk will actually get applied. > > Cc: stable@xxxxxxxxxxxxxxx > Reported-by: Andy Yang <andyybtc79@xxxxxxxxx> > Closes: https://lore.kernel.org/linux-ide/aFb3wXAwJSSJUB7o@ryzen/ > Fixes: b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SA motherboard") > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> > --- > drivers/ata/ahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index e5e5c2e81d09..aa93b0ecbbc6 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -1450,7 +1450,7 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) > { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > - DMI_MATCH(DMI_PRODUCT_VERSION, "ASUSPRO D840MB_M840SA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "ASUSPRO D840MB_M840SA"), > }, > /* 320 is broken, there is no known good version. */ > },
