Currently, the match table in ahci_broken_lpm() contains DMI BIOS dates
of BIOSes that are known to be working.
Having a list of known to be working versions is usually the wrong way to
do things (as this list could theoretically be infinite).
Refactor this match table to contain DMI BIOS dates of BIOSes that are
known to not be working, such that this list can be extended with BIOS
versions (for other boards) that are known to not be working, where there
is no good BIOS version (because all existing versions are broken).
Reviewed-by: Hans de Goede <hansg@xxxxxxxxxx>
Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>
---
drivers/ata/ahci.c | 28 ++++++++++++++++++++++------
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index e7c8357cbc54..05ff03b80b85 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1411,34 +1411,50 @@ static bool ahci_broken_suspend(struct pci_dev *pdev)
static bool ahci_broken_lpm(struct pci_dev *pdev)
{
static const struct dmi_system_id sysids[] = {
- /* Various Lenovo 50 series have LPM issues with older BIOSen */
+ /* Table contains DMI BIOS dates of BIOSes with broken LPM. */
{
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X250"),
},
- .driver_data = "20180406", /* 1.31 */
+ /*
+ * 1.31, build date 20180406, has working LPM, mark any
+ * DMI BIOS date before that as broken.
+ */
+ .driver_data = "20180405",
},
{
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L450"),
},
- .driver_data = "20180420", /* 1.28 */
+ /*
+ * 1.28, build date 20180420, has working LPM, mark any
+ * DMI BIOS date before that as broken.
+ */
+ .driver_data = "20180419",
},
{
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T450s"),
},
- .driver_data = "20180315", /* 1.33 */
+ /*
+ * 1.33, build date 20180315, has working LPM, mark any
+ * DMI BIOS date before that as broken.
+ */
+ .driver_data = "20180314",
},
{
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad W541"),
},
- .driver_data = "20180409", /* 2.35 */
+ /*
+ * 2.35, build date 20180409, has working LPM, mark any
+ * DMI BIOS date before that as broken.
+ */
+ .driver_data = "20180408",
},
{ } /* terminate list */
};
@@ -1452,7 +1468,7 @@ static bool ahci_broken_lpm(struct pci_dev *pdev)
dmi_get_date(DMI_BIOS_DATE, &year, &month, &date);
snprintf(buf, sizeof(buf), "%04d%02d%02d", year, month, date);
- return strcmp(buf, dmi->driver_data) < 0;
+ return strcmp(buf, dmi->driver_data) <= 0;
}
static bool ahci_broken_online(struct pci_dev *pdev)
--
2.49.0
