Hello all, I was trying to understand ata_eh_set_lpm(), and decided that it needed some cleanups to make the code more understandable. Please have a look. Changes since v1: -Squashed patches 3 and 4 as requested by Damien. -Squashed patches 6 and 7 as requested by Damien. -Changed WARN_ON to WARN_ON_ONCE. -Changed patch 1 to remove parts of a comment that is no longer true. Niklas Cassel (5): ata: libata-eh: Update DIPM comments to reflect reality ata: libata-eh: Add ata_eh_set_lpm() WARN_ON_ONCE ata: libata-eh: Rename hipm and dipm variables ata: libata-eh: Rename no_dipm variable to be more clear ata: libata-eh: Keep DIPM disabled while modifying the allowed LPM states drivers/ata/libata-eh.c | 39 ++++++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 13 deletions(-) -- 2.49.0