Hello Damien, I was trying to understand ata_eh_set_lpm(), and decided that it needed some cleanups to make the code more understandable. Please have a look. Niklas Cassel (7): ata: libata-eh: Update DIPM comments to reflect reality ata: libata-eh: Add ata_eh_set_lpm() WARN_ON ata: libata-eh: Drop dipm variable ata: libata-eh: Introduce dev_has_dipm and dev_has_hipm variables ata: libata-eh: Rename no_dipm variable to be more clear ata: libata-eh: Host support has nothing to do with disabling DIPM ata: libata-eh: Always disable DIPM before calling set_lpm() callback drivers/ata/libata-eh.c | 41 ++++++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 13 deletions(-) -- 2.49.0