On 5/12/25 17:44, Niklas Cassel wrote:
> Commit affccb16c117 ("ata: ahci: print the lpm policy on boot") added a
> lpm-pol print during boot, which shows the LPM policy used by each port.
>
> While the LPM policy is usually determined by the Kconfig
> CONFIG_SATA_MOBILE_LPM_POLICY, the Kconfig value is overridden e.g. if
> firmware has marked the port as hotplug capable / external.
>
> Commit f97106b10d9a ("ata: ahci: Add debug print for external port") did
> add a debug print to show if LPM was disabled because firmware has marked
> the port as external, however, because devices having broken LPM (even
> though they claim to support it) is more common than one would have hoped,
> print "ext" during boot if firmware has marked the port is external.
>
> This will make it easier to debug certain LPM issues, e.g. if firmware has
> enabled/marked only some of the ports as hotplug capable / external.
>
> Before (port marked as external by firmware):
> ata1: SATA max UDMA/133 abar m4096@0xfebd3000 port 0xfebd3100 irq 57 lpm-pol 0
>
> After (port marked as external by firmware):
> ata1: SATA max UDMA/133 abar m4096@0xfebd3000 port 0xfebd3100 irq 57 lpm-pol 0 ext
>
> Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>
Applied to for-6.16. Thanks !
--
Damien Le Moal
Western Digital Research
