On 4/23/25 02:21, Igor Pylypiv wrote: > For ATA PASS-THROUGH + fixed format sense data + NCQ autosense > the INFORMATION sense data field is being written twice: > > - 1st write: (redundant) > scsi_set_sense_information() sets the INFORMATION field to ATA LBA. > This is incorrect for ATA PASS-THROUGH. > > - 2nd write: (correct) > ata_scsi_set_passthru_sense_fields() sets the INFORMATION field > to ATA ERROR/STATUS/DEVICE/COUNT(7:0) as per SAT spec. > > There is no user-visible issue because second write overwrites > the incorrect data from the first write. > > This patch eliminates the reduntant write by moving the INFORMATION > sense data field population logic to ata_scsi_qc_complete(). > > Signed-off-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx> Applied to for-6.16. Thanks ! -- Damien Le Moal Western Digital Research
