Control of the enable/disable state of an ATA device Command Duration Limits (CDL) features has issues: 1) Incorrect checks of the feature support for translating a MODE SELECT command 2) Incorrect feature state report translation in libata-scsi 3) The state reported when enabling the feature was being ignored, which caused needless SET FEATURES commands to be issued to the device, thus causing an unwanted reset of the CDL statistics log page (which is implied by any CDL activation action). Patches 2 to 5 patches address these issues. In addition to these, patch 1 corrects an incorrect function return type. Martin, I can take the scsi patch if you are OK with it. Or the reverse, you can take all patches through the scsi tree if you prefer. Please let me know. Changes from v1: - Added Patch 1 and 2 - Added review tags to patches 3, 4 and 5 Damien Le Moal (5): ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type ata: libata-scsi: Fail MODE SELECT for unsupported mode pages ata: libata-scsi: Fix ata_msense_control_ata_feature() ata: libata-scsi: Improve CDL control scsi: Improve CDL control drivers/ata/libata-scsi.c | 36 ++++++++++++++++++++++++++++-------- drivers/scsi/scsi.c | 36 ++++++++++++++++++++++++------------ 2 files changed, 52 insertions(+), 20 deletions(-) -- 2.49.0
