Re: [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Henry Martin <bsdhenrymartin@xxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Fri, 4 Apr 2025 11:22:06 +0200
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Niklas Cassel <cassel@xxxxxxxxxx>
In-reply-to: <20250404061438.67557-1-bsdhenrymartin@gmail.com>
References: <20250404061438.67557-1-bsdhenrymartin@gmail.com>
Ui-outboundreport: notjunk:1;M01:P0:5EydMVgJFUU=;524IjyqXC4wNhljffufiWc/e2EB HMx6wUUgxnJ7+NZEvEd8wXbuqoUr4I9SYAYmNAS2V+8j4k6oQLQFJxXytJybprKktB455fKne tfLQtuW6+4d9BzK77tR7wgxmNnMRCWCuC16Y0ITkEpqu6y3qWtTyHqMJ//yhTCOMiR0gejas7 +HSZ6I36PCOqFXcs77MceIZpBzYC3NW2zYJPR7C3ZciRZ48lKVQ6u/eRYOckqssL9q6ojh+3e js1X0ZZAeG/3dF+B/ryUmwsvDM0+ykOWXELJjkEmJlPzneHke51mjTkcVxohJHMrg2j4AsdFk w2OK6uB13hqQrhHnTTCE7I7FiVd002dJxAziDFqGNWra53Ob5HpfbXWpyIMgcOs+4sO+OYLE4 uT6KHB2k2OVyShAn3oxP13XqXFcJJQbEspRQDMLB4432YsRdIikSuQ/D1qAJAQKZ5xgw8tSw7 pkb/cCTmADMYlZsG5evlHEtCoY8YOYty2RmgwD6kJxFCMaVw9DOcadobPFRkF8SKzwSP/s/f/ Hop2fQmzf3bPk0urPEFcPkBzXeauuPKjntm14Xjjwukp6jJrvWO+jQ+VFuWhQufBj4LJvoWY8 lcuJy66+Z6XcizS0CN2IQ/cqGlEG68EhW/DTWKGPFXo9UNMi3YJBvsecHR+8lday3rUi1Lk+H JUq4w/P49ENNpq69HQEpZ2+wQ9o6qY79o43glXI+NKW70FZIbzUd06G6O80JYKeTXnm3J4O/7 jI+xIvXbGc4wmidtOAiKowB96X+WoUzd0IVzT5NHzwtgSJK+01VU7sdmq6WypHCKKmM0UqtTG S6KuMRWcoUHhc7aw9cqM2yiBb26gDVsJXr5oxnWZ2rSLMbE2HDksoY2otp+FY0OWTFgTAjwr7 FhVYF11gR0RPc+HOxDM93KrGgvuB+L3xIELEplsoggN/mBVVEwEbnphfj7brC7wSJPYFTRkBJ GQcd5/zkwv7V9Mwqys6V4VX2TKoQZkByFp55jdIv159bmgdIBcOpeyxjfXECpCkax9zIv/WeW FvRSTaAY85iVBOflGqosMGocx1UGU72KRp7y4jRLycK9ZYb/0DGD7kksplvdouuQlPQYMBJuu UOE4cR14SF7yiWk/fu5xPV0XSWeUo5k9hiVIMgo9A0dhLY28y7vsrxzHTJKhe6fLrnT4j3Dgl TdoqPHtG5HxUz6q3Q64bkHSvQV6lHiJw+Bc0mnxEGMPFEP5hyeqZpjIK+ooOWsepeC7appXc7 du0l6PbZbB1gg2beZaS4a18AkIJE/ToAFwPUAsPKk0WXLcfDdhfSMCgDGU4FJQT932tQz3iFV YH9KuyeROJQU+qRUHc+WhgSRu3HsTrukPt+kR9zu28r2ExUl+WWHy90mFpvQs6sq7PvMNjXK2 lkQnMQxSsFstSkaNRRjvBWzX2QSE1nzzBsPgP9YjGf9vnyno78Fafec2O8GGnuxYuf039Xkam nQLcr3/stuUSaCzzTLCQ/zug6RuU0+lFaAUmTcnYyWk3ow38pX/+sjhV3m8AIkk0VlbmjUw==
User-agent: Mozilla Thunderbird

…
> Add NULL check after devm_ioremap() to prevent this issue.

May you omit the word “potential” from the summary phrase?


…
> ---
> V1 -> V2: Correct commit message and keep a blank line after check.

Can such an adjustment become helpful for any more places?

Regards,
Markus

References:
- [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()
  - From: Henry Martin

Prev by Date: [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()
Next by Date: Re: [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field consistently
Previous by thread: [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()
Next by thread: Re: [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems] [Linux SCSI] [Linux RAID] [Git] [Kernel Newbies] [Linux Newbie] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Samba] [Device Mapper]