On Mon, Mar 24, 2025 at 09:17:57AM +0100, Geert Uytterhoeven wrote: > I started working on Zorro MFD a long time ago, but never finished... > https://web.git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/log/?h=zorro-mfd Uhm, that could be useful for this multi-device board, thanks! > > + /* Manually bind to all boards */ > > + while ((z = zorro_find_device(ZORRO_PROD_CSLAB_WARP_CTRL, z))) { > > + static struct zorro_device_id cswarp_ent = { > > + ZORRO_PROD_CSLAB_WARP_CTRL, 0 > > + }; > > + > > + pata_cswarp_probe(z, &cswarp_ent); > > This looks very hackish to me... > I guess it blows up when trying to unbind either the zorro8390 or > cswarp driver? Yes, this was clearly wrong. > > 157c Information > > 6400 ISDN Engine I [ISDN Interface] > > 2017 Vortex > > diff --git a/include/uapi/linux/zorro_ids.h b/include/uapi/linux/zorro_ids.h > > index 0be1fb0c3915..5736d2bf0295 100644 > > --- a/include/uapi/linux/zorro_ids.h > > +++ b/include/uapi/linux/zorro_ids.h > > @@ -455,6 +455,12 @@ > > #define ZORRO_PROD_CSLAB_WARP_CTRL ZORRO_ID(CSLAB, 0x65, 0) > > #define ZORRO_PROD_CSLAB_WARP_XROM ZORRO_ID(CSLAB, 0x66, 1) > > > > +#define ZORRO_MANUF_CSLAB 0x1400 > > +#define ZORRO_PROD_CSLAB_WARP_DDR3 ZORRO_ID(CSLAB, 0x3c, 0) > > +#define ZORRO_PROD_CSLAB_WARP_VRAM ZORRO_ID(CSLAB, 0x64, 0) > > +#define ZORRO_PROD_CSLAB_WARP_CTRL ZORRO_ID(CSLAB, 0x65, 0) > > +#define ZORRO_PROD_CSLAB_WARP_XROM ZORRO_ID(CSLAB, 0x66, 1) > > + > > This does not belong in this patch, and adds duplicates? After submitting i noticed the duplication... anyhow, these ids changes are not necessary for this submission and i'll remove them in v2. -- bye, p.
