Hi Paolo, On Fri, 21 Mar 2025 at 16:14, Paolo Pisati <p.pisati@xxxxxxxxx> wrote: > Signed-off-by: Paolo Pisati <p.pisati@xxxxxxxxx> Thanks for your patch! > --- a/include/uapi/linux/zorro_ids.h > +++ b/include/uapi/linux/zorro_ids.h > @@ -450,7 +450,10 @@ > #define ZORRO_PROD_VMC_HYPERCOM_4 ZORRO_ID(VMC, 0x02, 0) > > #define ZORRO_MANUF_CSLAB 0x1400 > -#define ZORRO_PROD_CSLAB_WARP_1260 ZORRO_ID(CSLAB, 0x65, 0) This removes a definition; was it incorrect? Please explain in the patch description, especially as this is a uapi header file. > +#define ZORRO_PROD_CSLAB_WARP_DDR3 ZORRO_ID(CSLAB, 0x3c, 0) > +#define ZORRO_PROD_CSLAB_WARP_VRAM ZORRO_ID(CSLAB, 0x64, 0) > +#define ZORRO_PROD_CSLAB_WARP_CTRL ZORRO_ID(CSLAB, 0x65, 0) > +#define ZORRO_PROD_CSLAB_WARP_XROM ZORRO_ID(CSLAB, 0x66, 1) What do these represent? Please explain in the patch description. > > #define ZORRO_MANUF_INFORMATION 0x157C > #define ZORRO_PROD_INFORMATION_ISDN_ENGINE_I ZORRO_ID(INFORMATION, 0x64, 0) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds