Re: [PATCH v5 8/9] ovl: Check for casefold consistency when creating new dentries

[Amir Goldstein <amir73il@xxxxxxxxx>]

On Thu, Aug 14, 2025 at 7:22 PM André Almeida <andrealmeid@xxxxxxxxxx> wrote:
>
> In a overlayfs with casefold enabled, all new dentries should have
> casefold enabled as well. Check this at ovl_create_real().
>
> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx>
> ---
> Changes from v4:
> - Add pr_warn()
>
> Changes from v3:
> - New patch
> ---
>  fs/overlayfs/dir.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
> index 70b8687dc45e8e33079c865ae302ac58464224a6..88e888ed8696363d6cde39817f6c21e795f0760a 100644
> --- a/fs/overlayfs/dir.c
> +++ b/fs/overlayfs/dir.c
> @@ -187,6 +187,12 @@ struct dentry *ovl_create_real(struct ovl_fs *ofs, struct dentry *parent,
>                         /* mkdir is special... */
>                         newdentry =  ovl_do_mkdir(ofs, dir, newdentry, attr->mode);
>                         err = PTR_ERR_OR_ZERO(newdentry);
> +                       /* expect to inherit casefolding from workdir/upperdir */
> +                       if (!err && ofs->casefold != ovl_dentry_casefolded(newdentry)) {
> +                               pr_warn_ratelimited("dentry wrong casefold inheritance");

pr_warn_ratelimited("wrong inherited casefold (%pd2)\n", newdentry);

No need to report.
I can fix that on commit.

Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>


Thanks,
Amir.