On Thu, Aug 21, 2025 at 03:18:11PM -0700, Joanne Koong wrote:
> On Wed, Aug 20, 2025 at 5:52 PM Darrick J. Wong <djwong@xxxxxxxxxx> wrote:
> >
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> >
> > Turn on syncfs for all fuse servers so that the ones in the know can
> > flush cached intermediate data and logs to disk.
> >
> > Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> > ---
> > fs/fuse/inode.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >
> > diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> > index 463879830ecf34..b05510799f93e1 100644
> > --- a/fs/fuse/inode.c
> > +++ b/fs/fuse/inode.c
> > @@ -1814,6 +1814,7 @@ int fuse_fill_super_common(struct super_block *sb, struct fuse_fs_context *ctx)
> > if (!sb_set_blocksize(sb, ctx->blksize))
> > goto err;
> > #endif
> > + fc->sync_fs = 1;
>
> AFAICT, this enables syncfs only for fuseblk servers. Is this what you
> intended?
I meant to say for all fuseblk servers, but TBH I can't see why you
wouldn't want to enable it for non-fuseblk servers too?
(Maybe I was being overly cautious ;))
--D
>
> Thanks,
> Joanne
> > } else {
> > sb->s_blocksize = PAGE_SIZE;
> > sb->s_blocksize_bits = PAGE_SHIFT;
> >
