Re: [PATCH] fs: Document 'name' parameter in name_contains_dotdot()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 24, 2025 at 02:06:23AM +0100, Al Viro wrote:
> On Sat, Aug 23, 2025 at 07:52:08PM +0530, Prithvi Tambewagh wrote:
> > Add documentation for the 'name' parameter in name_contains_dotdot()
> > 
> > Signed-off-by: Prithvi Tambewagh <activprithvi@xxxxxxxxx>
> 
> Out of curiosity, could you describe the process that has lead to
> that patch?
> 
> The reason why I'm asking is that there had been a truly ridiculous
> amount of identical patches, all dealing with exact same function.
> 
> Odds of random coincedence are very low - there's quite lot of
> similar places, and AFAICS you are the 8th poster choosing the
> same one.
> 
> I would expect that kind of response to a "kernel throws scary
> warnings on boot for reasonably common setups", but for a comment
> about a function being slightly wrong this kind of focus is
> strange.
> 
> If that's some AI (s)tool responding to prompts along the lines of
> "I want to fix some kernel problem, find some low-hanging fruit
> and gimme a patch", we might be seeing a small-scale preview of
> a future DDoS with the same underlying mechanism...

You do know that kernel-doc warns about this, right?

    $ ./scripts/kernel-doc -v -none include/linux/fs.h
    [...]
    Warning: include/linux/fs.h:3287 function parameter 'name' not described in 'name_contains_dotdot'

It's the only warning in include/linux/fs.h.

- Eric




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux