On Mon, Aug 25, 2025 at 02:40:53PM +0200, Christian Brauner wrote: > Another thing, did I miss > > commit aab771f34e63ef89e195b63d121abcb55eebfde6 > Author: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > AuthorDate: Wed Jun 18 18:23:41 2025 -0400 > Commit: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > CommitDate: Sun Jun 29 19:03:46 2025 -0400 > > take freeing of emptied mnt_namespace to namespace_unlock() > > on the list somehow? I just saw that "emptied_ns" thing for the first > time and was very confused where that came from. I don't see any lore > link attached to the commit message. https://lore.kernel.org/all/20250623045428.1271612-35-viro@xxxxxxxxxxxxxxxxxx/ and https://lore.kernel.org/all/20250630025255.1387419-45-viro@xxxxxxxxxxxxxxxxxx/ in the next iteration of the same patchset, both Cc'd to you. As for the reasons, there are nasty hidden constraints caused by mount notifications; even though all mounts are out of that namespace, we can't free it until the calls of mnt_notify(), which come from notify_mnt_list(), from namespace_unlock(). Better handle it that way than have a recurring headache; besides, it helps with cleaning post-unlock_mount() stuff.
