Re: [REGRESSION] loop: use vfs_getattr_nosec for accurate file size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Theodore

It should be fixed by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=d14469ed7c00314fe8957b2841bda329e4eaf4ab

On Wed, Aug 27, 2025 at 11:00 AM Theodore Ts'o <tytso@xxxxxxx> wrote:
>
> Hi, I was testing 6.17-rc3, and I noticed a test failure in fstest
> generic/563[1], when testing both ext4 and xfs.  If you are using my
> test appliance[2], this can be trivially reproduced using:
>
>    kvm-xfstests -c ext4/4k generic/563
> or
>    kvm-xfstests -c xfs/4k generic/563
>
> [1] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/tests/generic/563
> [2] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md
>
> A git bisect pointed the problem at:
>
> commit 47b71abd58461a67cae71d2f2a9d44379e4e2fcf
> Author: Rajeev Mishra <rajeevm@xxxxxxx>
> Date:   Mon Aug 18 18:48:21 2025 +0000
>
>     loop: use vfs_getattr_nosec for accurate file size
>
>     Use vfs_getattr_nosec() in lo_calculate_size() for getting the file
>     size, rather than just read the cached inode size via i_size_read().
>     This provides better results than cached inode data, particularly for
>     network filesystems where metadata may be stale.
>
>     Signed-off-by: Rajeev Mishra <rajeevm@xxxxxxx>
>     Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
>     Link: https://lore.kernel.org/r/20250818184821.115033-3-rajeevm@xxxxxxx
>     [axboe: massage commit message]
>     Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>
> ... and indeed if I go to 6.17-rc3, and revert this commit,
> generic/563 starts passing again.
>
> Could you please take a look, and/or revert this change?  Many thanks!
>
>                                         - Ted
>


-- 
Best Regards,
  Yi Zhang






[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux