On Wed, 27 Aug 2025 at 21:02, Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > IOWs, would you be willing to rename this to FUSE_DEV_IOC_SET_FEATURE > and take a u32 code? Then programs with an open /dev/fuse fd can > incrementally add pieces as required. The first one would be > FUSE_DEV_SYNC_INIT, the second one would be FUSE_DEV_ADD_IOMAP, etc. Okay, so this is not a mask, and individual features would need to be set with separate ioctl calls, right? That would allow negotiating features. > > + return (typeof(fud)) ((unsigned long) fud & FUSE_DEV_PTR_MASK); > > s/unsigned long/uintptr_t/ here ? Okay. > If process_init_reply hits the ok==false case and clears fc->conn_init, > should this return an error here to abort the mount? Yes, fixed. Thanks, Miklos
