That stuff had been discussed last cycle, didn't make it into
-next back then. If nobody objects, I'm throwing that branch into
#for-next.
vfs_parse_fs_string() calling conventions are inconvenient;
it takes string and length, and just about every caller (with only two
exceptions) passes string, strlen(string).
Proposal: introduce vfs_parse_fs_qstr() for those that want
the generic form (and pass &QSTR_LEN(string, length) as its argument)
and lose the length argument of vfs_parse_fs_string().
Callers are happier that way. The first commit in the series does
the calling convention change and converts existing users; the second one
converts a couple of open-coded vfs_parse_fs_string() in do_nfs4_mount()
to that primitive. A lot more readable that way, IMO...
Branch (-rc1-based) lives in
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.fs_context
Individual patches in followups.
Please, review. If there's no objections, into -next it goes...
Shortlog:
Al Viro (2):
change the calling conventions for vfs_parse_fs_string()
do_nfs4_mount(): switch to vfs_parse_fs_string()
Diffstat:
Documentation/filesystems/mount_api.rst | 10 +++++++-
Documentation/filesystems/porting.rst | 10 ++++++++
drivers/gpu/drm/i915/gem/i915_gemfs.c | 9 ++-----
drivers/gpu/drm/v3d/v3d_gemfs.c | 9 ++-----
fs/afs/mntpt.c | 3 ++-
fs/fs_context.c | 17 ++++++-------
fs/namespace.c | 8 +++---
fs/nfs/fs_context.c | 3 +--
fs/nfs/namespace.c | 3 ++-
fs/nfs/nfs4super.c | 44 +++++++++------------------------
fs/smb/client/fs_context.c | 4 +--
include/linux/fs_context.h | 9 +++++--
kernel/trace/trace.c | 3 +--
13 files changed, 58 insertions(+), 74 deletions(-)
