On Fri, Aug 29, 2025 at 11:59:55AM +0200, Christian Brauner wrote: > On Fri, Aug 29, 2025 at 07:05:22AM +0100, Al Viro wrote: > > Take the identical logics in vfs_create_mount() and clone_mnt() into > > a new helper that takes an empty struct mount and attaches it to > > given dentry (sub)tree. > > > > Should be called once in the lifetime of every mount, prior to making > > it visible in any data structures. > > > > After that point ->mnt_root and ->mnt_sb never change; ->mnt_root > > is a counting reference to dentry and ->mnt_sb - an active reference > > to superblock. > > > > Mount remains associated with that dentry tree all the way until > > the call of cleanup_mnt(), when the refcount eventually drops > > to zero. > > > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > --- > > Is this supposed to be the v3? I'm confused what I need to be looking > at since it's a reply to v2 and some earlier review comments... It would be in v3, but I didn't feel like sending another 63-patch mailbomb for the sake of these 4 changed commits (well, and a cosmetical change in #33, with matching modification in #35, ending with both being cleaner - with the same resulting tree after #35). These 4 do repace #59..#62 in v3.