Re: [PATCH v2 01/12] mm: pass number of pages to __folio_start_writeback()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 3, 2025 at 1:05 PM David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> On 03.09.25 22:02, Darrick J. Wong wrote:
> > On Wed, Sep 03, 2025 at 01:48:41PM +0200, David Hildenbrand wrote:
> >> On 30.08.25 01:39, Joanne Koong wrote:
> >>> Add an additional arg to __folio_start_writeback() that takes in the
> >>> number of pages to write back.
> >>
> >> Usually we pass something like page+nr_pages so we know the actual range. I
> >> assume here this is not required, because we only care about using the
> >> #pages for accounting purposes, right?
> >
> > I think all the "nr_pages" here are actually the number of dirty pages
> > in the folio, right?  Or so I gather since later patches have iomap
> > walking bitmaps to find all the set/clear bits.  Perhaps that parameter
> > ought to be called nr_dirty(_pages)?
>
> That would make perfect sense to me :)

I will rename this to nr_dirty_pages to make this more clear / less confusing.

Thanks,
Joanne
>
> --
> Cheers
>
> David / dhildenb
>





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux