On Wed, Sep 3, 2025 at 1:43 PM Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > > On Fri, Aug 29, 2025 at 04:56:18PM -0700, Joanne Koong wrote: > > Iterate through the entire folio in iomap_readpage_iter() in one go > > instead of in pieces. This will be needed for supporting user-provided > > async read folio callbacks (not yet added). This additionally makes the > > iomap_readahead_iter() logic simpler to follow. > > This might be a good time to change the name since you're not otherwise > changing the function declaration, and there ought to be /some/ > indication that the behavior isn't the same anymore. > Actually, I was thinking "iomap_readpage_iter" makes even more sense for this function now as a name lol. Before it was not really iterating over anything, it just handled one particular range, but now it's actually iterating over a folio for all its ranges. I'm happy to change this though. But I'm not sure if there's a better name, iomap_read_folio() is already taken. Thanks, Joanne > Otherwise, this looks correct to me. > > --D > > > Signed-off-by: Joanne Koong <joannelkoong@xxxxxxxxx> > > --- > > fs/iomap/buffered-io.c | 76 ++++++++++++++++++------------------------ > > 1 file changed, 33 insertions(+), 43 deletions(-) > >
