Re: [PATCH 1/6] fs/proc: Don't look root inode when creating "self" and "thread-self"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 06, 2025 at 06:50:05AM +0100, Al Viro wrote:
> On Sat, Sep 06, 2025 at 02:57:05PM +1000, NeilBrown wrote:
> > From: NeilBrown <neil@xxxxxxxxxx>
> > 
> > proc_setup_self() and proc_setup_thread_self() are only called from
> > proc_fill_super() which is before the filesystem is "live".  So there is
> > no need to lock the root directory when adding "self" and "thread-self".
> > 
> > The locking rules are expected to change, so this locking will become
> > anachronistic if we don't remove it.
> 
> Please, leave that one alone.  FWIW, in tree-in-dcache branch (will push
> tomorrow or on Sunday, once I sort the fucking #work.f_path out) there's
> this:

PS: you do realize that we have similar things in devpts, binder, functionfs,
etc., right?  What's special about procfs?




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux