Re: [PATCH 04/21] done_path_create(): constify path argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat 06-09-25 10:11:20, Al Viro wrote:
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/namei.c            | 2 +-
>  include/linux/namei.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 869976213b0c..3eb0408e3400 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -4170,7 +4170,7 @@ struct dentry *kern_path_create(int dfd, const char *pathname,
>  }
>  EXPORT_SYMBOL(kern_path_create);
>  
> -void done_path_create(struct path *path, struct dentry *dentry)
> +void done_path_create(const struct path *path, struct dentry *dentry)
>  {
>  	if (!IS_ERR(dentry))
>  		dput(dentry);
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index 5d085428e471..75c0b665fbd4 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -60,7 +60,7 @@ extern int kern_path(const char *, unsigned, struct path *);
>  
>  extern struct dentry *kern_path_create(int, const char *, struct path *, unsigned int);
>  extern struct dentry *user_path_create(int, const char __user *, struct path *, unsigned int);
> -extern void done_path_create(struct path *, struct dentry *);
> +extern void done_path_create(const struct path *, struct dentry *);
>  extern struct dentry *kern_path_locked(const char *, struct path *);
>  extern struct dentry *kern_path_locked_negative(const char *, struct path *);
>  extern struct dentry *user_path_locked_at(int , const char __user *, struct path *);
> -- 
> 2.47.2
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux