On Sat 06-09-25 10:11:17, Al Viro wrote:
> Callers never use the resulting pointer to modify the struct path it
> points to (nor should they).
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/file_table.c | 2 +-
> include/linux/fs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 81c72576e548..85b53e39138d 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -54,7 +54,7 @@ struct backing_file {
>
> #define backing_file(f) container_of(f, struct backing_file, file)
>
> -struct path *backing_file_user_path(const struct file *f)
> +const struct path *backing_file_user_path(const struct file *f)
> {
> return &backing_file(f)->user_path;
> }
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index d7ab4f96d705..3bcc878817be 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2879,7 +2879,7 @@ struct file *dentry_open_nonotify(const struct path *path, int flags,
> const struct cred *cred);
> struct file *dentry_create(const struct path *path, int flags, umode_t mode,
> const struct cred *cred);
> -struct path *backing_file_user_path(const struct file *f);
> +const struct path *backing_file_user_path(const struct file *f);
>
> /*
> * When mmapping a file on a stackable filesystem (e.g., overlayfs), the file
> --
> 2.47.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
