On Tue 09-09-25 09:54:58, Mateusz Guzik wrote: > Similar to may_open(). > > No functional changes. > > Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx> Looks sane. Just one style nit below. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> > - else if (S_ISSOCK(mode)) > - ; /* leave it no_open_fops */ > - else > + break; > + case S_IFSOCK: > + /* leave it no_open_fops */ > + break; > + default: > printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o) for" > " inode %s:%lu\n", mode, inode->i_sb->s_id, > inode->i_ino); > + break; We usually don't bother with 'break' for the 'default' label. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
