On 9/10/2025 10:05 PM, Al Viro wrote:
> Nothing outside of fs/dcache.c has any business modifying
> dentry names; passing &dentry->d_name as an argument should
> have that argument declared as a const pointer.
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
For the Smack bit:
Acked-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>
> ---
> include/linux/lsm_hook_defs.h | 2 +-
> include/linux/security.h | 4 ++--
> security/security.c | 2 +-
> security/selinux/hooks.c | 2 +-
> security/smack/smack_lsm.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h
> index fd11fffdd3c3..aa4d6ec9c98b 100644
> --- a/include/linux/lsm_hook_defs.h
> +++ b/include/linux/lsm_hook_defs.h
> @@ -85,7 +85,7 @@ LSM_HOOK(int, -EOPNOTSUPP, dentry_init_security, struct dentry *dentry,
> int mode, const struct qstr *name, const char **xattr_name,
> struct lsm_context *cp)
> LSM_HOOK(int, 0, dentry_create_files_as, struct dentry *dentry, int mode,
> - struct qstr *name, const struct cred *old, struct cred *new)
> + const struct qstr *name, const struct cred *old, struct cred *new)
>
> #ifdef CONFIG_SECURITY_PATH
> LSM_HOOK(int, 0, path_unlink, const struct path *dir, struct dentry *dentry)
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 521bcb5b9717..3f694d3ebd70 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -391,7 +391,7 @@ int security_dentry_init_security(struct dentry *dentry, int mode,
> const char **xattr_name,
> struct lsm_context *lsmcxt);
> int security_dentry_create_files_as(struct dentry *dentry, int mode,
> - struct qstr *name,
> + const struct qstr *name,
> const struct cred *old,
> struct cred *new);
> int security_path_notify(const struct path *path, u64 mask,
> @@ -871,7 +871,7 @@ static inline int security_dentry_init_security(struct dentry *dentry,
> }
>
> static inline int security_dentry_create_files_as(struct dentry *dentry,
> - int mode, struct qstr *name,
> + int mode, const struct qstr *name,
> const struct cred *old,
> struct cred *new)
> {
> diff --git a/security/security.c b/security/security.c
> index ad163f06bf7a..db2d75be87cc 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -1775,7 +1775,7 @@ EXPORT_SYMBOL(security_dentry_init_security);
> * Return: Returns 0 on success, error on failure.
> */
> int security_dentry_create_files_as(struct dentry *dentry, int mode,
> - struct qstr *name,
> + const struct qstr *name,
> const struct cred *old, struct cred *new)
> {
> return call_int_hook(dentry_create_files_as, dentry, mode,
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index c95a5874bf7d..58ce49954206 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2901,7 +2901,7 @@ static int selinux_dentry_init_security(struct dentry *dentry, int mode,
> }
>
> static int selinux_dentry_create_files_as(struct dentry *dentry, int mode,
> - struct qstr *name,
> + const struct qstr *name,
> const struct cred *old,
> struct cred *new)
> {
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index fc340a6f0dde..5caa372ffbf3 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -4908,7 +4908,7 @@ static int smack_inode_copy_up_xattr(struct dentry *src, const char *name)
> }
>
> static int smack_dentry_create_files_as(struct dentry *dentry, int mode,
> - struct qstr *name,
> + const struct qstr *name,
> const struct cred *old,
> struct cred *new)
> {
