On Fri, Sep 12, 2025 at 06:39:28PM +0200, Jan Kara wrote: > > Shouldn't this ref put at the end of the function? > > It is put: > > > > + while (1) { > > > + list = llist_del_all(&new_wb->switch_wbs_ctxs); > > > + /* Nothing to do? */ > > > + if (!list) { > > > + wb_put(new_wb); > ^^^^ here > There's no other way how to exit the function... But I can put 'break' here > and do wb_put() at the end of the function. That will likely be less > subtle. Ah, sorry about missing that. Yeah, maybe better to put it ouside the loop to make it clearer. Acked-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun