Re: [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Fri, 12 Sep 2025 19:57:20 +0200
Cc: Jonathan Corbet <corbet@xxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Nicolas Pitre <nico@xxxxxxxxxxx>, Muchun Song <muchun.song@xxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Baoquan He <bhe@xxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>, Dave Young <dyoung@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Reinette Chatre <reinette.chatre@xxxxxxxxx>, Dave Martin <Dave.Martin@xxxxxxx>, James Morse <james.morse@xxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, "Liam R . Howlett" <Liam.Howlett@xxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, Andrey Konovalov <andreyknvl@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Pedro Falcato <pfalcato@xxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, Jason Gunthorpe <jgg@xxxxxxxxxx>
In-reply-to: <9c9f9f9eaa7ae48cc585e4789117747d90f15c74.1757534913.git.lorenzo.stoakes@oracle.com>
User-agent: Mozilla Thunderbird

On 10.09.25 22:22, Lorenzo Stoakes wrote:

Now we have the f_op->mmap_prepare() hook, having a static function called
__mmap_prepare() that has nothing to do with it is confusing, so rename the
function to __mmap_setup().

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
---


Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers

David / dhildenb

Follow-Ups:
- Re: [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion
  - From: Lorenzo Stoakes

References:
- [PATCH v2 00/16] expand mmap_prepare functionality, port more users
  - From: Lorenzo Stoakes
- [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion
  - From: Lorenzo Stoakes

Prev by Date: Re: ->atomic_open() fun (was Re: [RFC] a possible way of reducing the PITA of ->d_name audits)
Next by Date: Re: [RFC] does # really need to be escaped in devnames?
Previous by thread: [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion
Next by thread: Re: [PATCH v2 05/16] mm/vma: rename __mmap_prepare() function to avoid confusion
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]