在 2025/8/13 1:55, Vishal Moola (Oracle) 写道:
[You don't often get email from vishal.moola@xxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
On Tue, Aug 12, 2025 at 05:46:47PM +0100, Lorenzo Stoakes wrote:
On Tue, Aug 12, 2025 at 09:52:25PM +0800, Qianfeng Rong wrote:
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
`GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean up these
redundant flags across subsystems.
No functional changes.
Reviewed-by: Harry Yoo <harry.yoo@xxxxxxxxxx>
Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx>
LGTM, I wonder if there are other such redundancies in the kernel?
Looks like theres a lot left for this specific case. At least 48 show up
that are spread out across subsystems when running 'git grep
"GFP_NOWAIT.*GFP_NOWARN"'.
I think they should be cleaned up in sets per-subsystem to minimize
merge conflicts, as suggested in the commit mentioned above (16f5dfbc851b).
I agree. I submitted similar patches for each subsystem separately.
It may take some time to see the code merged into the next branch.
Best regards,
Qianfeng
