在 2025/8/12 21:11, Harry Yoo 写道:
[You don't often get email from harry.yoo@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On Tue, Aug 12, 2025 at 05:57:46PM +0800, Qianfeng Rong wrote:Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made GFP_NOWAIT implicitly include __GFP_NOWARN. Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean up these redundant flags across subsystems. No functional changes. Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx> ---Maybe .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN | __GFP_NOMEMALLOC | GFP_NOWAIT, in mm/damon/paddr.c also can be cleaned up to .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | | __GFP_NOMEMALLOC | GFP_NOWAIT, ?
Thanks for the reminder. I did miss one modification spot. After checking, I found this code section was moved to mm/damon/ops-common.c. I'll submit v2 immediately. Best regards, Qianfeng
With or without that: Reviewed-by: Harry Yoo <harry.yoo@xxxxxxxxxx> -- Cheers, Harry / Hyeonggon
