On 2025-08-11 13:50:23, Christoph Hellwig wrote: > On Mon, Jul 28, 2025 at 10:30:18PM +0200, Andrey Albershteyn wrote: > > From: Andrey Albershteyn <aalbersh@xxxxxxxxxx> > > > > The fsverity descriptor is stored in the extended attributes of the > > inode. Add new attribute type for fs-verity metadata. Add > > XFS_ATTR_INTERNAL_MASK to skip parent pointer and fs-verity attributes > > as those are only for internal use. While we're at it add a few comments > > in relevant places that internally visible attributes are not suppose to > > be handled via interface defined in xfs_xattr.c. > > So ext4 and other seems to place the descriptor just before the verity > data. What is the benefit of an attr? > Mostly because it was already implemented. But looking for benefits, attr can be inode LOCAL so a bit of saved space? Also, seems like a better interface than to look at a magic offset -- - Andrey