On 2025-08-11, Askar Safin <safinaskar@xxxxxxxxxxxx> wrote:
> ...because it is not used
Doing some spelunking, this usage was removed in commit 43f5e655eff7e,
when David split out the (MS_REMOUNT|MS_BIND) handling. As such, maybe
this deserves a
Fixed: 43f5e655eff7 ("vfs: Separate changing mount flags full remount")
...?
And feel free to take my
Reviewed-by: Aleksa Sarai <cyphar@xxxxxxxxxx>
Thanks!
> Signed-off-by: Askar Safin <safinaskar@xxxxxxxxxxxx>
> ---
> fs/namespace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index ddfd4457d338..dbc773b36d49 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -3279,7 +3279,7 @@ static int do_reconfigure_mnt(struct path *path, unsigned int mnt_flags)
> * If you've mounted a non-root directory somewhere and want to do remount
> * on it - tough luck.
> */
> -static int do_remount(struct path *path, int ms_flags, int sb_flags,
> +static int do_remount(struct path *path, int sb_flags,
> int mnt_flags, void *data)
> {
> int err;
> @@ -4109,7 +4109,7 @@ int path_mount(const char *dev_name, struct path *path,
> if ((flags & (MS_REMOUNT | MS_BIND)) == (MS_REMOUNT | MS_BIND))
> return do_reconfigure_mnt(path, mnt_flags);
> if (flags & MS_REMOUNT)
> - return do_remount(path, flags, sb_flags, mnt_flags, data_page);
> + return do_remount(path, sb_flags, mnt_flags, data_page);
> if (flags & MS_BIND)
> return do_loopback(path, dev_name, flags & MS_REC);
> if (flags & (MS_SHARED | MS_PRIVATE | MS_SLAVE | MS_UNBINDABLE))
> --
> 2.47.2
>
>
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
Attachment:
signature.asc
Description: PGP signature
