On Thu, Aug 7, 2025 at 12:06 AM Ibrahim Jirdeh <ibrahimjirdeh@xxxxxxxx> wrote: > > These patches are in order to add support for restarting permission > events which is useful for HSM use cases which are backed by a daemon > to respond reliably [1]. > > In terms of testing, there is an additional LTP test attached which > exercises releasing queue via the new api [2] > > [1] https://lore.kernel.org/linux-fsdevel/6za2mngeqslmqjg3icoubz37hbbxi6bi44canfsg2aajgkialt@c3ujlrjzkppr/ > [2] https://github.com/ibrahim-jirdeh/ltp/commit/ec38a798b823954f5c5f801b006257ff278f523b > Nice test. Gave some minor comments on github. I would add two things: 1. Test close of control fd before queue fd - Read from queue of shutdown group should fail 2. Generate two events but read/restart only one of them - Read event after re-open queue fd should get the first event not the second one Second read should get the second event Thanks and nice work! Amir.