Stefan Metzmacher <metze@xxxxxxxxx> wrote: > > + if (server->noblocksnd) > > + smb_msg->msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL; > > + else > > + smb_msg->msg_flags = MSG_NOSIGNAL; > > + smb_msg->msg_flags = MSG_SPLICE_PAGES; > > + > > I guess you want '|=' instead of '=' in all 3 lines? Well on the third line. msg_flags is 0 on entry to the function. > I also think msghdr should be setup in the caller completely > or it should be a local variable in smb_sendmsg() and the caller > only passes struct iov_iter. Yeah, makes sense. David
