On 2025-08-06, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Thu, Aug 07, 2025 at 03:55:23AM +1000, Aleksa Sarai wrote: > > > - goto err_free; > > - ret = -EFAULT; > > - if (copy_to_user(_buf, p, n) != 0) > > - goto err_free; > > + if (copy_to_user(_buf, p, n)) > > + n = -EFAULT; > > ret = n; > > - > > -err_free: > > if (need_free) > > kfree(p); > > return ret; > > Minor nit: seeing that there's only one path to that return, I would > rather turn it into > return n; > and dropped the assignment to ret a few lines above. Anyway, that's > trivially done when applying... It felt odd to use "return ret;" at the start and switch to "return n;" at the end, but feel free to change it when applying. > Anyway, who's carrying fscontext-related stuff this cycle? I've got > a short series in that area, but there won't be much from me around > there - a plenty of tree-in-dcache stuff, quite a bit of mount-related > work, etc., but not a lot around the options-parsing machinery. > > Christian, do you have any plans around that area? -- Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/
Attachment:
signature.asc
Description: PGP signature
