Re: [PATCH v1 1/2] fuse: disallow dynamic inode blksize changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 4, 2025 at 10:11 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Mon, 4 Aug 2025 at 23:10, Joanne Koong <joannelkoong@xxxxxxxxx> wrote:
> >
> > With fuse using iomap, which relies on inode->i_blkbits for its internal
> > bitmap tracking, disallow fuse servers from dynamically changing the
> > inode blocksize.
> >
> > "attr->blksize = sx->blksize;" is retained in fuse_statx_to_attr() so
> > that any attempts by the server to change the blksize through the statx
> > reply is surfaced to dmesg.
>
> I expect no big breakage, but I'm quite sure that message will scare
> some people for no good reason.  I'd just keep a copy of attr->blksize
> in fuse_inode and present that in stx_blksize, while keeping the
> internal i_blkbits consistent.
>
> Thoughts?

That sounds great and will make things simpler. We don't need the 2nd
patch then, I'll drop that in v2.

Thanks,
Joanne
>
> Thanks,
> Miklos





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux