This patch creates a new v9fs_context structure which includes v9fs_session_info as well as p9_client, p9_fd_opts, and p9_rdma_opts to hold all parsed options. The new structure will be used in the next commit to pass all parsed options to the appropriate transports. Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- fs/9p/cache.c | 1 + fs/9p/v9fs.h | 49 --------------------- include/net/9p/client.h | 88 ++++++++++++++++++++++++++++++++++++++ include/net/9p/transport.h | 32 -------------- 4 files changed, 89 insertions(+), 81 deletions(-) diff --git a/fs/9p/cache.c b/fs/9p/cache.c index 12c0ae29f185..1def4dec1dcc 100644 --- a/fs/9p/cache.c +++ b/fs/9p/cache.c @@ -12,6 +12,7 @@ #include <linux/sched.h> #include <linux/fs.h> #include <net/9p/9p.h> +#include <net/9p/client.h> #include "v9fs.h" #include "cache.h" diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h index f28bc763847a..4b8834daec8d 100644 --- a/fs/9p/v9fs.h +++ b/fs/9p/v9fs.h @@ -81,55 +81,6 @@ enum p9_cache_bits { CACHE_FSCACHE = 0b10000000, }; -/** - * struct v9fs_session_info - per-instance session information - * @flags: session options of type &p9_session_flags - * @nodev: set to 1 to disable device mapping - * @debug: debug level - * @afid: authentication handle - * @cache: cache mode of type &p9_cache_bits - * @cachetag: the tag of the cache associated with this session - * @fscache: session cookie associated with FS-Cache - * @uname: string user name to mount hierarchy as - * @aname: mount specifier for remote hierarchy - * @maxdata: maximum data to be sent/recvd per protocol message - * @dfltuid: default numeric userid to mount hierarchy as - * @dfltgid: default numeric groupid to mount hierarchy as - * @uid: if %V9FS_ACCESS_SINGLE, the numeric uid which mounted the hierarchy - * @clnt: reference to 9P network client instantiated for this session - * @slist: reference to list of registered 9p sessions - * - * This structure holds state for each session instance established during - * a sys_mount() . - * - * Bugs: there seems to be a lot of state which could be condensed and/or - * removed. - */ - -struct v9fs_session_info { - /* options */ - unsigned int flags; - unsigned char nodev; - unsigned short debug; - unsigned int afid; - unsigned int cache; -#ifdef CONFIG_9P_FSCACHE - char *cachetag; - struct fscache_volume *fscache; -#endif - - char *uname; /* user name to mount as */ - char *aname; /* name of remote hierarchy being mounted */ - unsigned int maxdata; /* max data for client interface */ - kuid_t dfltuid; /* default uid/muid for legacy support */ - kgid_t dfltgid; /* default gid for legacy support */ - kuid_t uid; /* if ACCESS_SINGLE, the uid that has access */ - struct p9_client *clnt; /* 9p client */ - struct list_head slist; /* list of sessions registered with v9fs */ - struct rw_semaphore rename_sem; - long session_lock_timeout; /* retry interval for blocking locks */ -}; - /* cache_validity flags */ #define V9FS_INO_INVALID_ATTR 0x01 diff --git a/include/net/9p/client.h b/include/net/9p/client.h index 2d46f8017bd5..33b8d9a79fa7 100644 --- a/include/net/9p/client.h +++ b/include/net/9p/client.h @@ -132,6 +132,94 @@ struct p9_client { char name[__NEW_UTS_LEN + 1]; }; +/** + * struct p9_fd_opts - per-transport options for fd transport + * @rfd: file descriptor for reading (trans=fd) + * @wfd: file descriptor for writing (trans=fd) + * @port: port to connect to (trans=tcp) + * @privport: port is privileged + */ + +struct p9_fd_opts { + int rfd; + int wfd; + u16 port; + bool privport; +}; + +/** + * struct p9_rdma_opts - Collection of mount options for rdma transport + * @port: port of connection + * @privport: Whether a privileged port may be used + * @sq_depth: The requested depth of the SQ. This really doesn't need + * to be any deeper than the number of threads used in the client + * @rq_depth: The depth of the RQ. Should be greater than or equal to SQ depth + * @timeout: Time to wait in msecs for CM events + */ +struct p9_rdma_opts { + short port; + bool privport; + int sq_depth; + int rq_depth; + long timeout; +}; + +/** + * struct v9fs_session_info - per-instance session information + * @flags: session options of type &p9_session_flags + * @nodev: set to 1 to disable device mapping + * @debug: debug level + * @afid: authentication handle + * @cache: cache mode of type &p9_cache_bits + * @cachetag: the tag of the cache associated with this session + * @fscache: session cookie associated with FS-Cache + * @uname: string user name to mount hierarchy as + * @aname: mount specifier for remote hierarchy + * @maxdata: maximum data to be sent/recvd per protocol message + * @dfltuid: default numeric userid to mount hierarchy as + * @dfltgid: default numeric groupid to mount hierarchy as + * @uid: if %V9FS_ACCESS_SINGLE, the numeric uid which mounted the hierarchy + * @clnt: reference to 9P network client instantiated for this session + * @slist: reference to list of registered 9p sessions + * + * This structure holds state for each session instance established during + * a sys_mount() . + * + * Bugs: there seems to be a lot of state which could be condensed and/or + * removed. + */ +struct v9fs_session_info { + /* options */ + unsigned int flags; + unsigned char nodev; + unsigned short debug; + unsigned int afid; + unsigned int cache; +#ifdef CONFIG_9P_FSCACHE + char *cachetag; + struct fscache_volume *fscache; +#endif + + char *uname; /* user name to mount as */ + char *aname; /* name of remote hierarchy being mounted */ + unsigned int maxdata; /* max data for client interface */ + kuid_t dfltuid; /* default uid/muid for legacy support */ + kgid_t dfltgid; /* default gid for legacy support */ + kuid_t uid; /* if ACCESS_SINGLE, the uid that has access */ + struct p9_client *clnt; /* 9p client */ + struct list_head slist; /* list of sessions registered with v9fs */ + struct rw_semaphore rename_sem; + long session_lock_timeout; /* retry interval for blocking locks */ +}; + +/* Used by mount API to store parsed mount options */ +struct v9fs_context { + struct p9_client client_opts; + struct p9_fd_opts fd_opts; + struct p9_rdma_opts rdma_opts; + struct v9fs_session_info v9ses; +}; + /** * struct p9_fid - file system entity handle * @clnt: back pointer to instantiating &p9_client diff --git a/include/net/9p/transport.h b/include/net/9p/transport.h index 88702953b1ef..ebbb4b50ee20 100644 --- a/include/net/9p/transport.h +++ b/include/net/9p/transport.h @@ -21,38 +21,6 @@ #define P9_RDMA_RQ_DEPTH 32 #define P9_RDMA_TIMEOUT 30000 /* 30 seconds */ -/** - * struct p9_fd_opts - per-transport options for fd transport - * @rfd: file descriptor for reading (trans=fd) - * @wfd: file descriptor for writing (trans=fd) - * @port: port to connect to (trans=tcp) - * @privport: port is privileged - */ - -struct p9_fd_opts { - int rfd; - int wfd; - u16 port; - bool privport; -}; - -/** - * struct p9_rdma_opts - Collection of mount options for rdma transport - * @port: port of connection - * @privport: Whether a privileged port may be used - * @sq_depth: The requested depth of the SQ. This really doesn't need - * to be any deeper than the number of threads used in the client - * @rq_depth: The depth of the RQ. Should be greater than or equal to SQ depth - * @timeout: Time to wait in msecs for CM events - */ -struct p9_rdma_opts { - short port; - bool privport; - int sq_depth; - int rq_depth; - long timeout; -}; - /** * struct p9_trans_module - transport module interface * @list: used to maintain a list of currently available transports -- 2.50.0