Re: [PATCH] fs/Kconfig: Enable HUGETLBFS only if ARCH_SUPPORTS_HUGETLBFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le 29/07/2025 à 17:50, Christophe Leroy a écrit :


Le 15/07/2025 à 02:31, Andrew Morton a écrit :
On Mon, 14 Jul 2025 11:49:09 +0200 Borislav Petkov <bp@xxxxxxxxx> wrote:

On Mon, Jul 14, 2025 at 08:05:31AM +0530, Anshuman Khandual wrote:
The original first commit had added 'BROKEN', although currently there
are no explanations about it in the tree.

commit c0dde7404aff064bff46ae1d5f1584d38e30c3bf
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxx>
Date:   Sun Aug 17 21:23:57 2003 -0700

     Add CONFIG_BROKEN (default 'n') to hide known-broken drivers.

Thanks.  That was unkind of someone.  How's this?


From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: init/Kconfig: restore CONFIG_BROKEN help text
Date: Mon Jul 14 05:20:02 PM PDT 2025

Linus added it in 2003, it later was removed.  Put it back.

Was removed by:

commit 3be71ba84f17f39131900f44e8ef513c696a5b11
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxx>
Date:   Mon Sep 1 21:30:14 2003 -0700

     Instead of asking for "broken drivers", ask for a "clean compile".

     This makes "allyesconfig" do a better job.

Which was then later removed by:

commit 3636641bb2c7a806c1099ca092ec8cd180063f9b
Author: Adrian Bunk <bunk@xxxxxxxxx>
Date:   Fri Feb 3 03:04:00 2006 -0800

    [PATCH] don't allow users to set CONFIG_BROKEN=y

    Do not allow people to create configurations with CONFIG_BROKEN=y.

The sole reason for CONFIG_BROKEN=y would be if you are working on fixing a
    broken driver, but in this case editing the Kconfig file is trivial.

    Never ever should a user enable CONFIG_BROKEN.

    Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>

diff --git a/init/Kconfig b/init/Kconfig
index b9923b1434a2f..8b7abae87bf9c 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -31,19 +31,8 @@ config EXPERIMENTAL
 	  you say Y here, you will be offered the choice of using features or
 	  drivers that are currently considered to be in the alpha-test phase.

-config CLEAN_COMPILE
-	bool "Select only drivers expected to compile cleanly" if EXPERIMENTAL
-	default y
-	help
-	  Select this option if you don't even want to see the option
-	  to configure known-broken drivers.
-
-	  If unsure, say Y
-
 config BROKEN
 	bool
-	depends on !CLEAN_COMPILE
-	default y

 config BROKEN_ON_SMP
 	bool





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux