Hi Tamir, > On 13 Jul 2025, at 09:05, Tamir Duberstein <tamird@xxxxxxxxx> wrote: > > The reservation API is used by asahi; currently they use their own > abstractions but intend to use these when available. > > Rust Binder intends to use the reservation API as well. > > Daniel Almeida mentions a use case for `insert_limit`, but didn't name > it specifically. Here is a patch that tests your code on Tyr [0]. I sadly didn't realize in time that you were using impl RangeBounds as an argument to insert_limit(), which is even nicer :) Our internal tests still pass. I also double-checked that the kunit/doctests pass, just in case. > > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx> > --- > Changes in v2: > - Explain the need to disambiguate `Iterator::chain`. (Boqun Feng) > - Mention what `Guard::alloc` does in the doc comment. (Miguel Ojeda) > - Include new APIs in the module-level example. (Miguel Ojeda) > - Mention users of these APIs in the cover letter. > - Link to v1: https://lore.kernel.org/r/20250701-xarray-insert-reserve-v1-0-25df2b0d706a@xxxxxxxxx > > --- > Tamir Duberstein (3): > rust: xarray: use the prelude > rust: xarray: implement Default for AllocKind > rust: xarray: add `insert` and `reserve` > > include/linux/xarray.h | 2 + > lib/xarray.c | 28 ++- > rust/helpers/xarray.c | 5 + > rust/kernel/xarray.rs | 533 ++++++++++++++++++++++++++++++++++++++++++++++--- > 4 files changed, 536 insertions(+), 32 deletions(-) > --- > base-commit: 2009a2d5696944d85c34d75e691a6f3884e787c0 > change-id: 20250701-xarray-insert-reserve-bd811ad46a1d > > Best regards, > -- > Tamir Duberstein <tamird@xxxxxxxxx> > > Thanks a lot for working on this. It will definitely be used by us. Tested-By: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> Reviewed-By: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> [0] https://gitlab.freedesktop.org/panfrost/linux/-/commit/791de453eb103af37e3cc6825e042f26d4c76426
