On Thu, Jul 24, 2025 at 04:46:23PM +0100, Al Viro wrote: > On Thu, Jul 24, 2025 at 09:48:54AM +0200, Christoph Hellwig wrote: > > file_remove_privs_flags is only used inside of inode.c, mark it static. > > That's close being a revert of 66a67c860cce "fs: file_remove_privs_flags()"; > I've no objections per se, but at least a Cc to Kent and summary of the > history in commit message would be useful. > > AFAICS, the history is more or less "the only in-tree user got reverted > in August 2024 and hadn't come back since then; its removal did not > touch the export", but I've no idea if it has successors yet to be merged > back into the tree. > > Again, I've no problem with making the damn thing static, but some context > would be useful. Oh, that... That was for a buffered write path that didn't need the inode lock (if we're not extending we should be able to just lock all the folios - right?) - which got reverted due to some absolutely nutty page cache corruption that I was never able to track down. We still want that, but I won't get back to it in less than a year, bcachefs is currently in hard freeze and I've been snapping at people who come to me with feature requests...
